Fixes individual news article title - #699
Merged
Merged
Conversation
Member
|
I think we still want the page_title conditional so just move the news title check above it and use an elseif for page title
…Sent from my iPhone
On Dec 15, 2018, at 5:46 PM, Hank Tadeusiak ***@***.***> wrote:
fixes #685
I just switched 'page_title' to 'news.title' in the if statement.
This worked as every page(besides the news.html) grabs the overlay title from the url.
May want to look into a better solution down the road.
You can view, comment on, or merge this pull request online at:
#699
Commit Summary
fixes individual news article title, uses article name instead of part of page url
File Changes
M website/templates/snippets/display_short_carousel_snippet.html (4)
Patch Links:
https://github.com/jonfroehlich/makeabilitylabwebsite/pull/699.patch
https://github.com/jonfroehlich/makeabilitylabwebsite/pull/699.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Contributor
Author
|
This should be fixed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #685
I just switched 'page_title' to 'news.title' in the if statement.
This worked as every page(besides the news.html) grabs the overlay title from the url.
May want to look into a better solution down the road.